Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Stabilize for RTM #60294

Merged
merged 5 commits into from
Oct 19, 2021
Merged

[release/6.0] Stabilize for RTM #60294

merged 5 commits into from
Oct 19, 2021

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Oct 12, 2021

No description provided.

@ghost
Copy link

ghost commented Oct 12, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: mmitche
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@mmitche mmitche requested a review from Anipik October 12, 2021 15:17
@ViktorHofer
Copy link
Member

D:\a_work\1\s.dotnet\sdk\6.0.100-rc.1.21430.12\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "xunit.assert [2.4.2-pre.9, )" or update the version field in the nuspec. [D:\a_work\1\s\src\libraries\Microsoft.Extensions.DependencyInjection.Specification.Tests\src\Microsoft.Extensions.DependencyInjection.Specification.Tests.csproj]
##[error].dotnet\sdk\6.0.100-rc.1.21430.12\Sdks\NuGet.Build.Tasks.Pack\buildCrossTargeting\NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: (NETCORE_ENGINEERING_TELEMETRY=Build) A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "xunit.assert [2.4.2-pre.9, )" or update the version field in the nuspec.

It's probably easiest to just downgrade this product dependency to the latest stable release of xunit: 2.4.1 in src\libraries\Microsoft.Extensions.DependencyInjection.Specification.Tests\src\Microsoft.Extensions.DependencyInjection.Specification.Tests.csproj.

@ViktorHofer
Copy link
Member

/__w/1/s/src/libraries/workloads-testing.targets(95,5): error : Could not find cross compiler nupkg at /__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm.6.0.0-ci.nupkg. Found packages: /__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.MonoAOTCompiler.Task.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.MonoTargets.Sdk.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.wasm.Sample.Mono.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.WebAssembly.Sdk.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Workload.Mono.ToolChain.Manifest-6.0.100.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm.6.0.0.symbols.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.Mono.browser-wasm.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.Mono.browser-wasm.6.0.0.symbols.nupkg [/__w/1/s/src/tests/BuildWasmApps/Wasm.Build.Tests/Wasm.Build.Tests.csproj]

@steveisok who would be the best person to look into this error? @Anipik any idea why this didn't show up during the servicing readiness exercise?

@mmitche
Copy link
Member Author

mmitche commented Oct 12, 2021

/__w/1/s/src/libraries/workloads-testing.targets(95,5): error : Could not find cross compiler nupkg at /__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm.6.0.0-ci.nupkg. Found packages: /__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.MonoAOTCompiler.Task.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.MonoTargets.Sdk.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.wasm.Sample.Mono.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Runtime.WebAssembly.Sdk.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NET.Workload.Mono.ToolChain.Manifest-6.0.100.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm.6.0.0.symbols.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.Mono.browser-wasm.6.0.0.nupkg;/__w/1/s/artifacts/packages/Release/Shipping/Microsoft.NETCore.App.Runtime.Mono.browser-wasm.6.0.0.symbols.nupkg [/__w/1/s/src/tests/BuildWasmApps/Wasm.Build.Tests/Wasm.Build.Tests.csproj]

@steveisok who would be the best person to look into this error? @Anipik any idea why this didn't show up during the servicing readiness exercise?

Possibilities:

  • This didn't get built in the official build.
  • Something changed.

Anyways, why is a test package stabilizing? @Anipik did all the stabilization fixes make it into release/6.0?

@mmitche
Copy link
Member Author

mmitche commented Oct 12, 2021

Hold till 10/18

@ViktorHofer ViktorHofer added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) area-Infrastructure and removed area-Infrastructure-libraries labels Oct 12, 2021
@ViktorHofer ViktorHofer added this to the 6.0.0 milestone Oct 12, 2021
@ghost
Copy link

ghost commented Oct 12, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: mmitche
Assignees: -
Labels:

* NO MERGE *, area-Infrastructure

Milestone: -

@Anipik
Copy link
Contributor

Anipik commented Oct 12, 2021

Microsoft.Extensions.DependencyInjection.Specification.Tests shipping test package. we didnt hit this in servicing readiness because we just updated the xunit package.
cc @maryamariyan @ericstj

@radical
Copy link
Member

radical commented Oct 12, 2021

The version string is being used in the following places for wasm/workload testing:

  1. https://github.com/dotnet/runtime/blob/release/6.0/eng/testing/tests.wasm.targets#L79
  2. https://github.com/dotnet/runtime/blob/release/6.0/src/libraries/workloads-testing.targets#L92
  3. https://github.com/dotnet/runtime/blob/release/6.0/src/tests/BuildWasmApps/Wasm.Build.Tests/Wasm.Build.Tests.csproj#L38-L39

The logs show that for all the 3 cases, the version string being used is 6.0.0-ci, but IIUC, it should be 6.0.0. Are we using the wrong property?

The current failure is being caused (2).

@Anipik
Copy link
Contributor

Anipik commented Oct 12, 2021

i will take a look at the workloads failures

@ericstj
Copy link
Member

ericstj commented Oct 12, 2021

We should change these

<PackageReference Include="xunit.assert" Version="$(XUnitVersion)" />
<PackageReference Include="xunit.extensibility.core" Version="$(XUnitVersion)" />

Back to 2.4.1.

@mmitche
Copy link
Member Author

mmitche commented Oct 15, 2021

@Anipik We need to get this in first thing Monday morning, can it be green by EOD?

@Anipik
Copy link
Contributor

Anipik commented Oct 15, 2021

@Anipik We need to get this in first thing Monday morning, can it be green by EOD?

we need a stable dependency update from the wcf repo, that should fix the service model error

@Anipik
Copy link
Contributor

Anipik commented Oct 18, 2021

#60482

example green pr with no after reverting back to the wcf version. (i have ported most of it so we should be good after wcf update)

Created an issue for the failing test. It doesnt look like a blocking issue. #60532 i have tagged some folks there to verify it.

@Anipik Anipik removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 18, 2021
@mmitche
Copy link
Member Author

mmitche commented Oct 18, 2021

@safern We'll need the wcf build published and an input nuget feed for it. Build is currently ongoing.

@mmitche
Copy link
Member Author

mmitche commented Oct 18, 2021

Updated dependencies to stable versions.

@mmitche mmitche merged commit ba7a7bb into dotnet:release/6.0 Oct 19, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants